-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[perf] tags pool experiment #1521
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfd6ede
to
20984fe
Compare
2805078
to
c996c6c
Compare
c996c6c
to
222bd30
Compare
31cf834
to
1b1fdc0
Compare
prepare tags in the beginning of transaction increase amount of tags in pool x2
63c0b5a
to
1f314bf
Compare
Closing as not significant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is create to check GC behaviour on framework benchmark if we start using tags and transactions pools.
Where transaction pool is retainable and tags pool is predefined
Idea here is:
Tracker
classes, including it'sSets
and prepare initial pool (reusable)DirtyableTag
initial pool (not reusble)UpdatableTag
initial pool (not reusable)In abstract ember app we always need some amount of
Tracker
,DirtyableTag
andUpdatableTag
classes.And it may be a case where we will see GC improvements. And will be able to ship default pool sizes or allow developers to customize it from global variable or code replace functionality or babel plugin.