Add searchmoves functionality #677
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooskagh
reviewed
May 27, 2018
lc0/src/chess/uciloop.cc
Outdated
| @@ -133,11 +133,12 @@ bool UciLoop::DispatchCommand( | |||
| } else if (command == "go") { | |||
| GoParams go_params; | |||
| if (ContainsKey(params, "infinite")) { | |||
| if (!GetOrEmpty(params, "infinite").empty()) { | |||
lc0/src/mcts/search.cc
Outdated
| if (!limits_.searchmoves.empty() && | ||
| std::find(limits_.searchmoves.begin(), | ||
| limits_.searchmoves.end(), | ||
| iter->GetMove(root_color).as_string()) == |
There was a problem hiding this comment.
It's better to do vice versa, convert searchmoves from string to Move (somewhere before getting into Search class) and then compare.
For example, promotions can be encoded both as "e7e8q" and "e7e8Q", and I'm not sure how knight promotion works too.
added 3 commits
May 28, 2018 00:46
|
Oh, I noticed another problem. Probably need to filter moves when output best move also. |
|
Implementation through strings works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
go infinite searchmoves a2a3 b2b3