Adding Margin trading support, #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including Isolated buy sell , market buy, query max borrow and calculating the purchase power. additional close positions (sell and put)
glitch100
requested changes
Dec 4, 2021
| } | ||
| else if(asset == ((dynamic)x).quoteAsset.asset.Value) | ||
| {// the requested asset is the one used for quotes | ||
| freeCoins = decimal.Parse(((dynamic)x).quoteAsset.free.Value); |
There was a problem hiding this comment.
free is like cash, i used their term (.baseAsset.free.Value) - the free amount you may use.
regarding Coins, i'll take any suggestion
Co-authored-by: Jon Evans <[email protected]>
Adding isolated account info response updating .gitignore
…ince it uses market command internally
glitch100
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including Isolated buy sell , market buy, query max borrow and calculating the purchase power.
additional close positions (sell and put)
Overview
Solved Issues
N/A
Installation
N/A
Acceptance and Testing Steps
Other Notes