-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a timingPhaseDetail extension #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 97.71% 97.93% +0.22%
==========================================
Files 42 44 +2
Lines 2010 2184 +174
==========================================
+ Hits 1964 2139 +175
+ Misses 46 45 -1 ☔ View full report in Codecov by Sentry. |
and nested_extension property
function arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the description in https://github.com/globaldothealth/isaric3/blob/main/1_workstreams/1.01_ISARIC3/Timing_Variables.md
timingPhaseDetail
is a complex (i.e. nested) extension which in FHIR format appears aswhere the
timingDetail
portion can take either a valueCodeableConcept, valueRange, or valueString.Also edits the flow of the flat2fhir conversion to allow for this structure and cleans up the code a bit.