Porting mongo+srv support from new, offical mongo driver #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport the DNS service record capability of Mongo Atlas. This allows the mgo driver to support Atlas. Enterprising users can also create their own DNS service records to support their clust changing without needing to modify configuration variables.
ghost
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address issue #112 . The code changes are largely based on the new, official mongo driver. That code does not drop in cleanly, so the code was modified so that it works with mgo.
While a test does exist, it requires specific DNS configurations that have to be set up externally. This test can be modified to enable testing a connection to a cluster using the new mongo+srv URI format.