Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env var prefix support #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hltbra
Copy link

@hltbra hltbra commented Sep 22, 2014

This pull request needs some work if #8 gets merged.

I came up with this feature idea because I would like to add env var support to https://github.com/thumbor/thumbor, and thumbor has some env var names that may conflict with other programs if env vars are shared (i.e SENTRY_DSN_URL).

What do you guys think?

@heynemann
Copy link
Contributor

I like this a lot. Will give it some thought and review soon. What do you think @guilhermef ?

@guilhermef
Copy link
Contributor

I like this too, we never had this problem since we run most of our apps on isolated machines.

@rafaelcaricio
Copy link

What is necessary to make this move forward? I would like to use this feature in spec-first/connexion#367. Since it is a framework and naturally will be mixed with people's code makes sense to prefix all environment variables.

/ping @hltbra @heynemann @guilhermef

@heynemann
Copy link
Contributor

Well, first rebase with master then make all tests pass and add a couple more tests if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants