Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch HTTP to HTTPS protocol for script url in page template #253

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

josephburkhart
Copy link
Contributor

Description

Fix an issue where the x3dom code couldn't be loaded in the live/public version of the RTD build. This was caused by writing the url to the x3dom code with http instead of https. This issue is documented here and you can verify it by clicking on the lock symbol in your status bar and clicking "disable protections for this site" - suddenly the models render properly!

Motivation and Context

I want docs to work plz thx

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

Copy link
Contributor

@DomFijan DomFijan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything renders ok. Let's see if rendering is fixed on RTD live after this! Fingers crossed.

@janbridley janbridley merged commit 1d3fe2d into master Feb 24, 2025
10 checks passed
@janbridley janbridley deleted the docs-shape-render-hotfix branch February 24, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants