Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the pmft module to nanobind #1274

Merged
merged 25 commits into from
Sep 6, 2024
Merged

Convert the pmft module to nanobind #1274

merged 25 commits into from
Sep 6, 2024

Conversation

joaander
Copy link
Member

Description

Convert the pmft module to nanobind.

Motivation and Context

Part of the ongoing effort to move freud to nanobind.

How Has This Been Tested?

Execute existing unit tests.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@joaander joaander requested review from a team as code owners August 27, 2024 13:29
@joaander joaander requested review from b-butler and removed request for a team August 27, 2024 13:29
@joaander joaander changed the base branch from main to nanobind August 27, 2024 13:30
@joaander joaander requested a review from DomFijan August 28, 2024 17:25
@joaander joaander removed request for a team and b-butler August 28, 2024 17:25
@DomFijan
Copy link
Contributor

I will give it a look by Monday 9th at the latest.

@joaander
Copy link
Member Author

I will give it a look by Monday 9th at the latest.

OK, I'll have several more pull requests chained up by then.

@joaander
Copy link
Member Author

joaander commented Sep 5, 2024

The two follow up PRs are #1275 and #1278. We need all 3 merged before the hackathon.

@joaander joaander merged commit dbd7d5f into nanobind Sep 6, 2024
14 of 15 checks passed
@joaander joaander deleted the nanobind-pmft branch September 6, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants