Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting interface module #1280

Merged
merged 11 commits into from
Sep 17, 2024
Merged

Porting interface module #1280

merged 11 commits into from
Sep 17, 2024

Conversation

surajkannur
Copy link

@surajkannur surajkannur commented Sep 11, 2024 •
edited
Loading

Porting Interface module

Description

The interface module has been ported to pure python as part of shifting to use nanobind

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@surajkannur
Copy link
Author

pre-commit.ci autofix

@surajkannur
Copy link
Author

pre-commit.ci autofix

DomFijan
DomFijan reviewed Sep 11, 2024
View reviewed changes
freud/interface.py Outdated Show resolved Hide resolved
@surajkannur surajkannur marked this pull request as ready for review September 11, 2024 17:48
joaander
joaander approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joaander joaander merged commit 70ee09b into nanobind Sep 17, 2024
26 checks passed
@joaander joaander deleted the nanobind-interface branch September 17, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DomFijan DomFijan DomFijan left review comments

@joaander joaander joaander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surajkannur @joaander @DomFijan