Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test on GitHub actions and test with numpy 2.0. #56

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

joaander
Copy link
Member

@joaander joaander commented Jun 20, 2024

Migrate to GitHub Actions and test with numpy 2.0.

Fixes #55.

@joaander joaander force-pushed the github-actions-and-numpy-2.0 branch from 971366c to aee02ca Compare June 20, 2024 16:48
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (3dc9653) to head (2b02274).

Current head 2b02274 differs from pull request most recent head 7cf1ca0

Please upload reports for the commit 7cf1ca0 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files           7        7           
  Lines         608      608           
  Branches       67       67           
=======================================
  Hits          545      545           
  Misses         40       40           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaander joaander force-pushed the github-actions-and-numpy-2.0 branch 3 times, most recently from 5d741d1 to 491a116 Compare June 20, 2024 16:51
@joaander joaander force-pushed the github-actions-and-numpy-2.0 branch from 491a116 to 119cb4b Compare June 20, 2024 16:56
@joaander
Copy link
Member Author

Rowan passes numpy 2.0 tests with no modifications.

@joaander joaander marked this pull request as ready for review June 20, 2024 17:37
@joaander joaander force-pushed the github-actions-and-numpy-2.0 branch from e3586e0 to 7cf1ca0 Compare June 20, 2024 18:35
@joaander joaander requested a review from janbridley June 24, 2024 11:00
Copy link

@janbridley janbridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for porting over to Github Actions

@joaander joaander merged commit ff2febf into master Jun 24, 2024
8 of 9 checks passed
@joaander joaander deleted the github-actions-and-numpy-2.0 branch June 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Github Actions
2 participants