Require Python 3.8+. #715
Merged
Require Python 3.8+. #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
requested review from
cbkerr and
tommy-waltmann
and removed request for
a team
bdice
commented
Mar 16, 2022
| Some features such as the HDF5 integration require additional packages. | ||
| Supported Python and NumPy versions are determined according to the `NEP 29 deprecation policy <https://numpy.org/neps/nep-0029-deprecation_policy.html>`_. | ||
| The signac framework uses the `NEP 29 deprecation policy <https://numpy.org/neps/nep-0029-deprecation_policy.html>`__ as a guideline for when to drop support for Python and NumPy versions, and does not guarantee support beyond the versions recommended in that proposal. |
There was a problem hiding this comment.
If this language is approved, I will update signac-flow and signac-dashboard accordingly. Related conversation: #685 (comment)
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
==========================================
- Coverage 78.54% 78.51% -0.03%
==========================================
Files 65 65
Lines 7141 7141
Branches 1565 1565
==========================================
- Hits 5609 5607 -2
Misses 1228 1228
- Partials 304 306 +2
Continue to review full report at Codecov.
|
csadorf
approved these changes
Mar 16, 2022
Co-authored-by: Carl Simon Adorf <[email protected]>
tommy-waltmann
approved these changes
Mar 18, 2022
This was referenced Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NEP 29 has dropped support for Python < 3.8. This PR updates signac to require Python 3.8+. This will help with some current work for signac 2.0 where we would like to use newer language/library features.
In the meantime, I caught a problem where our Windows tests were using Python 3.7 instead of Python 3.8 as we intended. Since Python 3.7 is no longer supported, I updated it to Python 3.10 (the latest release at the time of writing) so that it would be running a supported version further into the future.
Checklist: