Generic asset/model/entity controller

[Pierstoval]

No description provided.

[cedric-anne]

This controller will probably be common to not only assets but most of the CommonDBTM classes. The technical names should not contains asset. Also, it could be considered as an index controller for the corresponding class.

• Glpi\Controller\Asset\CommonAssetController -> Glpi\Controller\CommonIndexController (or maybe GenericIndexController)
• /asset/{type}/search -> /{type}
• getAssetClass() -> getClass()

[Pierstoval]

Instead of "index" I suggest using the term "Model", because that's both self-explanatory and generic, wdyt?

We would then have "Model list", and "Model form", for routes and controllers naming

[cedric-anne]

Instead of "index" I suggest using the term "Model", because that's both self-explanatory and generic, wdyt?

We would then have "Model list", and "Model form", for routes and controllers naming

Model is already used from the functional point of view in GLPI. It refers to the hardware models. I think it would be confusing to use it here.

GenericList and GenericForm could be enough.

[Pierstoval]

For now, forms are not handled because they're much more complex.

Almost all standard cases are handled by this PR 👌

[cedric-anne]

This one does not work as expected. Indeed, as it is a CommonDropdown class, it is mapped with the DropdownController and the top menu/breadcrumbs are not correctly displayed.

The DropdownController is using the CommonDropdown::displayCentralHeader() that bases the header "sectorized details" based on the $first_level_menu, $second_level_menu and $third_level_menu properties.

We could completely remove the DropdownController usage by moving these properties into the getSectorizedDetails() method and applying the following patch:

diff --git a/src/Glpi/Http/LegacyDropdownRouteListener.php b/src/Glpi/Http/LegacyDropdownRouteListener.php
index 0c8e3ffe8e..3346d98240 100644
--- a/src/Glpi/Http/LegacyDropdownRouteListener.php
+++ b/src/Glpi/Http/LegacyDropdownRouteListener.php
@@ -37,8 +37,8 @@ namespace Glpi\Http;
 use Glpi\Asset\AssetDefinition;
 use Glpi\Asset\AssetModel;
 use Glpi\Asset\AssetType;
-use Glpi\Controller\DropdownController;
 use Glpi\Controller\DropdownFormController;
+use Glpi\Controller\GenericListController;
 use Glpi\Dropdown\Dropdown;
 use Glpi\Dropdown\DropdownDefinition;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
@@ -73,8 +73,13 @@ final readonly class LegacyDropdownRouteListener implements EventSubscriberInter
         if ($class = $this->findDropdownClass($request)) {
             $is_form = \str_ends_with($request->getPathInfo(), '.form.php');
 
-            $request->attributes->set('_controller', $is_form ? DropdownFormController::class : DropdownController::class);
-            $request->attributes->set('class', $class);
+            if ($is_form) {
+                $request->attributes->set('_controller', DropdownFormController::class);
+                $request->attributes->set('class', $class);
+            } else {
+                $request->attributes->set('_controller', GenericListController::class);
+                $request->attributes->set('type', $class);
+            }
         }
     }
 

[Pierstoval]

Apparently I can even do better: centralize everything in the existing listener and widening it to CommonDBTM instead of just CommonDropdown, and just add an "if" statement to distinguish between DropdownController and GenericListController.

Later on, in another PR, we might "merge" dropdown and generic list controllers

[cedric-anne]

DropdownController does the exact same as GenericListController, except that it displays the header using a different method.

[cedric-anne]

Please remove this file, it is out of the scope of this PR.

[cedric-anne]

IMHO, the type attribute should correspond to the real class name (at least for now).

The normalizeClass logic is already done on the listener side and is not required here.

[cedric-anne]

This class should be tested.