-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio service for Android (#39) #178
Conversation
Update from origin
modules/audio/src/main/native/android/dalvik/DalvikAudioService.java
Outdated
Show resolved
Hide resolved
A |
modules/audio/src/main/native/android/dalvik/DalvikAudioService.java
Outdated
Show resolved
Hide resolved
modules/audio/src/main/native/android/dalvik/DalvikAudioService.java
Outdated
Show resolved
Hide resolved
modules/audio/src/main/java/com/gluonhq/attach/audio/impl/AndroidAudioService.java
Outdated
Show resolved
Hide resolved
modules/audio/src/main/java/com/gluonhq/attach/audio/impl/AndroidAudioService.java
Outdated
Show resolved
Hide resolved
modules/audio/src/main/java/com/gluonhq/attach/audio/impl/AndroidAudioService.java
Outdated
Show resolved
Hide resolved
modules/audio/src/main/java/com/gluonhq/attach/audio/impl/AndroidAudioService.java
Outdated
Show resolved
Hide resolved
I've resolved remaining comments and extracted them here for clarity:
I propose we don't add any status related API in the first version on the basis that we can't reliably obtain that information for both music and audio. After the first version is released, the community feedback and use cases should help guide the public API, which will bring us much closer to the desired API than if we were to consider it only theoretically.
If the user wants to load the audio from a background thread, they can, for example, by using After these are resolved, I'll start finalizing the PR. |
I'm okay with your proposal. Audio status could be added later on if needed. |
This PR is now ready for a full review and then merge. Sample test video is available for Android 10, showing use of public API and working functionality for both music and sound. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the longer term, it would be good if we can have this for iOS and Android in OpenJFX, as an implementation for the OpenJFX API's.
For now, Attach is a good place to test and experiment.
@AlmasB Already filed this for you: gluonhq/gluonfx-maven-plugin#241 |
No description provided.