Fix indentation in generated plugin version file

The `plugin/create.rb` tests that passed a block to the `#create_plugin`
helper method weren't executing properly, as the blocks weren't actually
called.

When they were re-enabled, test that checked `version.rb` was failing,
with extra blank lines inserted between the code.

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.19.0 (Unreleased)
+
+* Fix whitespace in version.rb when generating new plugins. (Graham Ashton)
+
 ## 0.18.0 (19 November 2024)
 
 * Update Sinatra to 4.1, to fix a vulnerability.

lib/nesta/commands/plugin/create.rb

@@ -23,14 +23,14 @@ def module_name
         def nested_module_definition_with_version
           indent_with = '  '
 
-          lines = module_names.map { |name| "module #{name}\n" }
+          lines = module_names.map { |name| "module #{name}" }
           indent_levels = 0.upto(module_names.size - 1).to_a
 
-          lines << "VERSION = '0.1.0'\n"
+          lines << "VERSION = '0.1.0'"
           indent_levels << module_names.size
 
           (module_names.size - 1).downto(0).each do |indent_level|
-            lines << "end\n"
+            lines << 'end'
             indent_levels << indent_level
           end
 

templates/plugins/lib/version.rb

@@ -1,5 +1,5 @@
 module Nesta
   module Plugin
-<%= nested_module_definition_with_version -%>
+<%= nested_module_definition_with_version %>
   end
 end

test/integration/commands/plugin/create_test.rb

@@ -34,6 +34,7 @@ def create_plugin(&block)
     Dir.chdir(working_directory) do
       command = Nesta::Commands::Plugin::Create.new(plugin_name)
       command.execute(process_stub)
+      block.call
     end
   end