-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated block models for v2 #125
Open
Tim-Evans-Seequent
wants to merge
45
commits into
gmggroup:dev
Choose a base branch
from
seequent:blockmodel
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Block models v2
Added examples of writing and reading block models.
tests/test_doc_example.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tim-Evans-Seequent can you please delete this file?
ThomasMatern
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context and scope
OMF v1 only supports regular and tensor block models. This means that applications can't use it to store sub-blocked models. OMF v2 should support common regular sub-blocking schemes like those used by Deswik, Surpac, Datamine, and Vulcan as well as have room to store less common or application-specific free-form sub-blocks.
There was previous work done in this area but it was incomplete and doesn't do what we need it to do. That works is discarded by this PR.
Existing Code
In OMF v1 block models are saved using the
VolumeGridGeometry
class. This is a grid that can have values on block centroids or corners. Rotation was supported by directly specifying the U, V, and W direction vectors of the block model space. These directions were required to be orthogonal so skew was not supported. Positions was specified with the origin point on the ProjectElementGeometry super-class. Block spacing did not need to be regular, with arrays of offsets along those U, V, and W directions explicitly specified. A regular block model just used regularly spaced offsets.Goals and non-goals
Design
Common block model base class
The common base for block models will contain:
Regular block grid
Adds a parent block size and a block count in each direction.
Tensor block grid
Adds arrays of sizes along the U, V, and W axes.
Regular sub-blocks
These sub-blocks must lie on regular a grid inside each parent block. They stored as a list of corner indices on that sub-grid. Check the documentation changes in this PR for details. Below is a 2D example of parent indices and corners for some sub-blocks:
These can be further restricted/documented with an octree or fully sub-blocked mode.
Free-form sub-blocks
These sub-blocks aren't restricted to any sort of grid inside the parent. They are still stored as a list of corners but the values are floating-point and range from 0.0 to 1.0 across the parent block. The positions are always relative to the parent block so there's no large offset added on making the floats less precise.