-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ujson bridge #401
add ujson bridge #401
Conversation
Hi @esarbe. Thanks for the contribution, new library support is always awesome. Can you please run |
case "replace" => | ||
val path = readPointer(value) | ||
val payload = | ||
try value.obj("value") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there a way with ujson to check for existence before failing instead of try/catch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, there's the .get(key)
method that behaves pretty much like in maps.
But we'll end up throwing exceptions anyway, it's the idiomatic way to propagate error in ujson/upickle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rewrote the bridge without try/catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with ujson
but if that's the idiomatic way, then it's ok.
Applied Fixed it and pushed. |
The license header is part of the check indeed, the year and authors are configured in the build and checked by the CI, so build won't pass if they do not match the configuration. |
Updated the build. |
Checks fail at binary compatibility checks, which is not surprising, since there are no previous binaries to compare to. I can change this, but I don't know what your preferred approach to this "new library bridge" problem is. |
In this case, you can use the |
Add a ujson/upickle implementation