Swift: Add a config option for prefixing all containers #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callum027
force-pushed
the
swift-container-prefix
branch
3 times, most recently
from
3c648cd to
75bef24
Compare
The `swift_container_prefix` option by itself only prefixes the containers created for metric storage. This is not enough to allow multiple Gnocchi deployments to share the same OpenStack project, as additional containers are created for Gnocchi configuration as well as for incoming metric storage, if Swift is also used as the incoming storage driver. This adds a new `swift_container_prefix_all` flag for enabling prepending `swift_container_prefix` to **all** Swift containers that can be made by Gnocchi. This allows new deployments of Gnocchi to be configured in a way that multiple deployments can share the project (e.g. a service project in a multi-region cloud). Unfortunately, existing Gnocchi deployments cannot easily be reconfigured to enable prefixes, nor can the prefix easily be changed. Fixes gnocchixyz#1067.
Callum027
force-pushed
the
swift-container-prefix
branch
from
75bef24 to
d54d501
Compare
rafaelweingartner
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
swift_container_prefixoption by itself only prefixes the containers created for metric storage.This is not enough to allow multiple Gnocchi deployments to share the same OpenStack project, as additional containers are created for Gnocchi configuration as well as for incoming metric storage, if Swift is also used as the incoming storage driver.
This adds a new
swift_container_prefix_allflag for enabling prependingswift_container_prefixto all Swift containers that can be made by Gnocchi.This allows new deployments of Gnocchi to be configured in a way that multiple deployments can share the project (e.g. a service project in a multi-region cloud). Unfortunately, existing Gnocchi deployments cannot easily be reconfigured to enable prefixes, nor can the prefix easily be changed.
Fixes #1067.