fix: narrow TransactionRequest type to indicate it's serializable (#33

) closes #32
gnosisguild · Jan 30, 2025 · 946b81b · 946b81b
1 parent b48ccbe
commit 946b81b
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/bun.lockb b/bun.lockb
diff --git a/package.json b/package.json
@@ -28,11 +28,11 @@
   },
   "devDependencies": {
     "@gnosis-guild/zodiac-core": "^2.0.4",
-    "@types/bun": "^1.1.15",
+    "@types/bun": "^1.2.1",
     "@types/wait-on": "^5.3.4",
     "prettier": "^3.4.2",
-    "tsup": "^8.1.0",
-    "typescript": "^5.7.2",
+    "tsup": "^8.3.6",
+    "typescript": "^5.7.3",
     "wait-on": "8.0.1"
   },
   "dependencies": {
@@ -41,6 +41,6 @@
     "@safe-global/protocol-kit": "^5.1.1",
     "@safe-global/safe-deployments": "^1.37.22",
     "@safe-global/types-kit": "^1.0.1",
-    "viem": "^2.22.4"
+    "viem": "^2.22.17"
   }
 }
diff --git a/src/encode/execTransaction.ts b/src/encode/execTransaction.ts
@@ -1,5 +1,5 @@
-import { Address, encodeFunctionData, Hex, parseAbi } from 'viem'
-import { SafeTransactionRequest, TransactionRequest } from '../types'
+import { encodeFunctionData, Hex, parseAbi } from 'viem'
+import { SafeTransactionRequest } from '../types'
 
 const abi = parseAbi([
   'function execTransaction(address to, uint256 value, bytes data, uint8 operation, uint256 safeTxGas, uint256 baseGas, uint256 gasPrice, address gasToken, address refundReceiver, bytes signatures) payable returns (bool success)',

diff --git a/src/execute/types.ts b/src/execute/types.ts
@@ -1,7 +1,11 @@
-import type { Address, TransactionRequest, TypedDataDomain } from 'viem'
+import type { Address, TypedDataDomain } from 'viem'
 import type { SafeTransactionOptionalProps } from '@safe-global/protocol-kit'
 
-import type { ChainId, PrefixedAddress, SafeTransactionRequest } from '../types'
+import type {
+  ChainId,
+  SafeTransactionRequest,
+  TransactionRequest,
+} from '../types'
 
 export enum ExecutionActionType {
   EXECUTE_TRANSACTION = 'EXECUTE_TRANSACTION',