This repository has been archived by the owner on Jul 19, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started down this path, hoping that we could have some default custom buffer for e.g. cuda blocks, but there is no support for the transfer_type which is not known at block instantiation. This needs more thought about what we want the custom buffer api to be.
One benefit of having the custom buffer associated with the port is that we can do something like
Is that better? I'm not sure.
Signed-off-by: Josh Morman [email protected]