Skip to content
This repository has been archived by the owner on Jul 19, 2022. It is now read-only.

wip: move the buffer spec to port #140

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mormj
Copy link
Contributor

@mormj mormj commented Oct 21, 2021

Started down this path, hoping that we could have some default custom buffer for e.g. cuda blocks, but there is no support for the transfer_type which is not known at block instantiation. This needs more thought about what we want the custom buffer api to be.

One benefit of having the custom buffer associated with the port is that we can do something like

graph.connect(x,y)
x.output_port(0).set_custom_buffer(...)

Is that better? I'm not sure.

Signed-off-by: Josh Morman [email protected]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant