Load dynamic libraries on darwin

[LittleChimera]

Followup on #3669
Resolves #1628

[aarzilli]

Do TestListImages, TestPluginStepping and TestPluginVariables pass on macOS with this? The WithPlugins function that disables them wasn't changed.

[LittleChimera]

Do TestListImages, TestPluginStepping and TestPluginVariables pass on macOS with this? The WithPlugins function that disables them wasn't changed.

Yes, at least as far as I can tell. I'm running it on M1 Air with MacOS 15.2.

edit: however. i cannot confirm these fail on master either.

[aarzilli]

Yes, at least as far as I can tell.

Did you comment out the line at pkg/proc/test/support.go:359 or exclude darwin?

[LittleChimera]

Yes, at least as far as I can tell.

Did you comment out the line at pkg/proc/test/support.go:359 or exclude darwin?

thanks for the pointer. Seems like I wasn't getting the feedback the test was skipped. Looks like TestListImages fails after enabling plugin tests on darwin.

[aarzilli]

thanks for the pointer. Seems like I wasn't getting the feedback the test was skipped. Looks like TestListImages fails after enabling plugin tests on darwin.

Do you mean in CI or also on your computer?

[LittleChimera]

thanks for the pointer. Seems like I wasn't getting the feedback the test was skipped. Looks like TestListImages fails after enabling plugin tests on darwin.

Do you mean in CI or also on your computer?

I mean on my machine (see attachment). Other tests run fine. CI seems to fail only for Go 1.24 if I understand correctly?

TestListImages.run.txt

[aarzilli]

thanks for the pointer. Seems like I wasn't getting the feedback the test was skipped. Looks like TestListImages fails after enabling plugin tests on darwin.

Do you mean in CI or also on your computer?

I mean on my machine (see attachment). Other tests run fine. CI seems to fail only for Go 1.24 if I understand correctly?

TestListImages.run.txt

This could be just a problem with the test:

    /Users/lukaskugor/projects/github.com/delve/pkg/proc/proc_test.go:4009:     0x148284000 "/private/var/folders/cd/0k_ctr913rs8ncf7nqtjzhv40000gn/T/plugin1.d0a8ccca" err:<nil>
    /Users/lukaskugor/projects/github.com/delve/pkg/proc/proc_test.go:4015: Could not find plugin1

plugin1 is there but the test doesn't find it, probably because of the symlink stuff that macos does.