proc: some refactorings for supporting struct literals #3909
+91
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekparker
reviewed
Feb 5, 2025
| @@ -43,3 +45,9 @@ func Or(x, y ast.Expr) ast.Expr { | |||
| } | |||
| return &ast.BinaryExpr{Op: token.LOR, X: x, Y: y} | |||
| } | |||
|
|
|||
| func ExprToString(t ast.Expr) string { | |||
| @@ -1101,3 +1101,16 @@ func zeroArray(t Type) { | |||
| t = at.Type | |||
| } | |||
| } | |||
|
|
|||
| func ResolveTypedef(typ Type) Type { | |||
* deduplicates exprToString, defined in multiple packages, and moves it to astutil * moves resolveTypedef into pkg/dwarf/godwarf, this is currently only used by pkg/proc but we will need to call it from pkg/proc/evalop * creates a new FakePointerType function in pkg/dwarf/godwarf, this is also a function that is only used by pkg/proc but pkg/proc/evalop will also need. Updates go-delve#1465
aarzilli
force-pushed
the
fncallpinner3
branch
from
7a3cc07 to
c1124be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to astutil
used by pkg/proc but we will need to call it from pkg/proc/evalop
also a function that is only used by pkg/proc but pkg/proc/evalop will
also need.
Updates #1465