chore: polish as master version

go-echarts · Jan 30, 2024 · 4c0b005 · 4c0b005
1 parent 4e41a2a
commit 4c0b005
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml
@@ -38,35 +38,39 @@ jobs:
           echo "Example repo ==>"
           ls examples/
 
-      - name: Run Examples generate original html files on tag
+      - name: Run Examples generate original html files based on master branch
+        working-directory: ./examples
         run: |
-          cd examples
           echo "Currently working on go-echarts version ===>"
+          echo "replace github.com/go-echarts/go-echarts/v2 => github.com/go-echarts/go-echarts/v2 master" >> go.mod
           cat go.mod
           go mod tidy
+          cat go.mod
           go run . false
 
       - name: Check Examples generate html files and mv as snapshot
+        working-directory: ./examples
         run: |
-          cd examples
           ls examples/html/
           mkdir -p examples/snapshot
           mv examples/html/*.html examples/snapshot/
           ls examples/snapshot/
 
       - name: Replace dependency as local
+        working-directory: ./examples
         run: |
-          cd examples
+          sed -i '/replace/d' go.mod
+          cat go.mod
           echo "replace github.com/go-echarts/go-echarts/v2 => ../../go-echarts" >> go.mod
 
       - name: Check Examples changed files
+        working-directory: ./examples
         run: |
-          cd examples
           cat go.mod
 
       - name: Run Examples generate html files
+        working-directory: ./examples
         run: |
-          cd examples
           go mod tidy
           go run . false
 

diff --git a/README.md b/README.md
@@ -17,7 +17,7 @@ and `go-echarts/examples` repo.
 The `go-echarts/examples` contains lots of showcases, it can be the test cases also.
 
 Idea of this pipeline is that we can compare the generated options (with latest `go-echarts` codebase)
-with the snapshot options (with latest `go-echarts` release version) to distinguish any breaking structure/option
+with the snapshot options (with latest `go-echarts` master branch) to distinguish any breaking structure/option
 change.
 
 Technically, it will mask all the `random` mock things such as `numbers`, `chartID`...etc and `function string`, then