feat: add Server option of WithStripTrailingSlash #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability for a user to implicitly strip all slashes from all routes as well as strip all ending slashes from all requests at the fuego Server level.
|
@EwenQuim I will be away from a computer starting friday until April. Please feel free to make changes to this. |
Understood. Have a good time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #366
Add the ability for a user to implicitly strip all slashes from all routes as well as strip all ending slashes from all requests at the fuego Server level.
This PR only makes this configurable at the level of the Server. This does come with a utility function to be able to configure path stripping at the route level but it's not incredibly useful (our uses should just do this themselves when they declare the path).
Let me know what you think. It may be worth make that option private as it's not really useful unless you're stripping at the global level.