Enable the iofs adapter to also return other interfaces from io/fs
#100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
This aligns the behaviour with chroot, as per use in go-git's default loader. Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Evan Anderson <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
The use of wasmbrowsertest in the latest versions of Ubuntu is failing due to changes to unprivileged apparmor sandbox. The existing test_wasip1 should provide the same assurances that WASM is still working. Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Bumping dependencies and forward ports
Bumps the golang-org group with 1 update: [golang.org/x/sys](https://github.com/golang/sys). Updates `golang.org/x/sys` from 0.28.0 to 0.29.0 - [Commits](golang/sys@v0.28.0...v0.29.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-org ... Signed-off-by: dependabot[bot] <[email protected]>
…-org-b711640f48 build: bump golang.org/x/sys from 0.28.0 to 0.29.0 in the golang-org group
Instead of relying on difficult casting, this improves developer experience by providing easy ways of convering a billy filesystem into the rest of the filesystem interfaces that are available in `io/fs`. This is a safe operation since we already ensure the type implements such interfaces some lines below my changes. Signed-off-by: Juan Antonio Osorio <[email protected]>
pjbgf
previously approved these changes
Jan 10, 2025
There was a problem hiding this comment.
@JAORMX LGTM for v5, so we will need to target this PR to releases/v5.x.
I am not sure this changes will make it to v6, as potentially we could have a better UX that removes their need. I created a new issue to improve the UX between go-billy and io/fs. Please add some information there on anything that could be improved on that front, so that it is taken into account as we make API changes for the next major release.
|
Please rebase based of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on difficult casting, this improves developer
experience by providing easy ways of convering a billy filesystem into
the rest of the filesystem interfaces that are available in
io/fs.This is a safe operation since we already ensure the type implements
such interfaces some lines below my changes.