feat: Support scenarios where split-table and non-table split tenants… #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exist simultaneously in multi-tenant situations Support scenarios where split-table and non-table split tenants exist simultaneously in multi-tenant situations
|
@huacnlee Can you help me, thanks? |
huacnlee
reviewed
Mar 20, 2024
| @@ -116,6 +116,10 @@ func (m ShardingMigrator) splitShardingDsts(dsts ...any) (shardingDsts []shardin | |||
| } | |||
|
|
|||
| for _, suffix := range suffixs { | |||
| if len(suffix) == 0 { | |||
There was a problem hiding this comment.
这里用 len(suffix) 能达到你的目的，但逻辑很奇怪。我们不能直接这样做
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… exist simultaneously in multi-tenant situations
Support scenarios where split-table and non-table split tenants exist simultaneously in multi-tenant situations
What did this pull request do?
User Case Description