Fix panic assigning to nil map

go-kivik · Dec 4, 2024 · bdb0600 · bdb0600
1 parent 0c1bf3f
commit bdb0600
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/couchdb/client.go b/couchdb/client.go
@@ -29,7 +29,7 @@ import (
 )
 
 func (c *client) AllDBs(ctx context.Context, opts driver.Options) ([]string, error) {
-	var query url.Values
+	query := url.Values{}
 	opts.Apply(&query)
 	var allDBs []string
 	err := c.DoJSON(ctx, http.MethodGet, "/_all_dbs", &chttp.Options{Query: query}, &allDBs)

diff --git a/couchdb/client_test.go b/couchdb/client_test.go
@@ -60,6 +60,12 @@ func TestAllDBs(t *testing.T) {
 		}, nil),
 		expected: []string{"_global_changes", "_replicator", "_users"},
 	})
+	tests.Add("with param", test{
+		client:  newTestClient(nil, errors.New("expected")),
+		options: kivik.Param("startkey", "bar"),
+		status:  http.StatusBadGateway,
+		err:     `Get "?http://example.com/_all_dbs\?startkey=bar"?: expected`,
+	})
 
 	tests.Run(t, func(t *testing.T, test test) {
 		opts := test.options