WIP: replaced stdlib encoding/json by jsoniter #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Oct 28, 2019
schema_loader.go
Outdated
| data, err := swag.LoadFromFileOrHTTP(path) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return json.RawMessage(data), nil | ||
| return stdjson.RawMessage(data), nil |
There was a problem hiding this comment.
return statements should not be cuddled if block has more than two lines (from wsl)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
==========================================
- Coverage 65.43% 65.35% -0.08%
==========================================
Files 29 29
Lines 2844 2849 +5
==========================================
+ Hits 1861 1862 +1
- Misses 820 823 +3
- Partials 163 164 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Frederic BIDON <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental: measure perf increase
Signed-off-by: Frederic BIDON [email protected]