Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add fully composable request and response middleware #902

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented Nov 6, 2024

  • PreRequestHook removed
  • Resty request and response middleware become exported
  • Any order of middleware insertion is feasible

Closes #811
Closes #345
Closes #665
Closes #747

- PreRequestHook removed
- Resty request and response middleware become exported
- Any order of middleware insertion is feasible
@jeevatkm jeevatkm added this to the v3.0.0 Milestone milestone Nov 6, 2024
@jeevatkm jeevatkm self-assigned this Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 94.54545% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.79%. Comparing base (f18ee43) to head (72cb565).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
middleware.go 95.77% 2 Missing and 1 partial ⚠️
request.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #902   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files          15       15           
  Lines        3230     3249   +19     
=======================================
+ Hits         3191     3210   +19     
  Misses         28       28           
  Partials       11       11           
Flag Coverage Δ
unittests 98.79% <94.54%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevatkm jeevatkm merged commit 2e14e51 into main Nov 6, 2024
7 checks passed
@jeevatkm jeevatkm deleted the composble-middlewares branch November 6, 2024 05:12
This was referenced Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant