Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry not reset multipartField reader #953

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: retry not reset multipartField reader #953

merged 2 commits into from
Jan 17, 2025

Conversation

wxip
Copy link
Contributor

@wxip wxip commented Jan 15, 2025

fix #952

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (16fd88a) to head (a902861).
Report is 1 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #953      +/-   ##
==========================================
+ Coverage   95.68%   95.70%   +0.01%     
==========================================
  Files          14       14              
  Lines        2203     2213      +10     
==========================================
+ Hits         2108     2118      +10     
  Misses         71       71              
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wxip Thanks for the PR. Can you please add test cases to cover PR changes?
See here - #953 (comment)

@wxip wxip requested a review from jeevatkm January 17, 2025 01:43
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wxip Thanks for adding test cases.

@jeevatkm jeevatkm merged commit 414b364 into go-resty:v2 Jan 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

retry not reset multipartFields reader when RetryResetReaders is true
2 participants