Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Namespace Tree Mapping) #90

Merged
merged 1 commit into from
Sep 2, 2023
Merged

fix(Namespace Tree Mapping) #90

merged 1 commit into from
Sep 2, 2023

Conversation

MaxCheetham
Copy link
Contributor

@MaxCheetham MaxCheetham commented Sep 2, 2023 •
edited
Loading

Fixing some issues around tasks and namespaces being mapped into the tree list view hierarchy.

  • Namespaces will now be created if they either don't have a direct child, or if their child is internal
  • Multi-level Namespaces render correctly

fixes #79, #59

@MaxCheetham MaxCheetham changed the title fix(#89, #59): Fix Namespace Tree Mapping fix(Namespace Tree Mapping) Sep 2, 2023
pd93
pd93 approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@pd93 pd93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for tackling this issue

@pd93 pd93 merged commit a5416bc into go-task:main Sep 2, 2023
3 checks passed
@MaxCheetham MaxCheetham deleted the fix/command-tree-mapping branch September 2, 2023 22:44
@pd93 pd93 linked an issue Sep 2, 2023 that may be closed by this pull request
The tree structure will be messed up when the parent namespace task is an internal task. #59
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pd93 pd93 pd93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@MaxCheetham @pd93