Add interceptors package with useful typed Goa interceptor functions #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
douglaswth
commented
Feb 6, 2025
•
douglaswth
commented
- Add Trace Stream family of interceptor functions which allow for tracing of individual messages sent on bidirectional, client to server, and server to client streams.
- Add tests for the interceptor functions.
- Fix typos in several READMEs.
- Add Trace Stream family of interceptor functions which allow for tracing of individual messages sent on bidirectional, client to server, and server to client streams. - Fix typos in several READMEs. [ ] Add tests for the interceptor functions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
+ Coverage 84.36% 85.17% +0.81%
==========================================
Files 36 39 +3
Lines 2066 2179 +113
==========================================
+ Hits 1743 1856 +113
Misses 297 297
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…nst changing the Goa interceptor interface to return a context
…mewhat since Go needs more explicit type parameters than it should)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.