-
-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/integrations: owncloud: document #12540
base: main
Are you sure you want to change the base?
website/integrations: owncloud: document #12540
Conversation
Apply changes from old MR
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Some easy fixes to match template
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12540 +/- ##
==========================================
- Coverage 92.76% 92.70% -0.06%
==========================================
Files 769 769
Lines 38911 38911
==========================================
- Hits 36095 36072 -23
- Misses 2816 2839 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for this review Tana. Didn't have a chance to finish cleaning the PR up after merging the old changes |
Cleans up the authentik configuration section of this documentation and removes unneeded bits
Add `### Configuration` header and switch General Settings, Protocl Settings, and Advanced Protocol Settings to H4
…move unneeded block Updates the service discovery block to be more in-line with documentation, renames "Apache" to "Apache HTTPD" (correct name), removes provider specific documentation for traefik and instead tells users to view provider-specific docs. Also removes section kept last commit
…ion" section Starts cleaning up the steps, adds warning for sub and the other one, grammar, styling and bla bla bla
Adds single quotes for client-id and client-secret lines. Should be fine I think. Logic says quotes but old docs had none
Cleanup and restructure the section
Cleanup the rest of the ownCloud section and update the loginButtonName variable
Lints the code with Prettier
Signed-off-by: 4d62 <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
|
||
- **Configure Bindings** (optional): To manage the listing and access to applications on a user's **My applications** page, you can optionally create a [binding](https://docs.goauthentik.io/docs/add-secure-apps/flows-stages/bindings/) between the application and a specific policy, group, or user. Keep in mind that if you do not specify any bindings, all users will have access to the application. For more information about user access, refer to our documentation about [authorization](https://docs.goauthentik.io/docs/add-secure-apps/applications/manage_apps#policy-driven-authorization) and [hiding an application](https://docs.goauthentik.io/docs/add-secure-apps/applications/manage_apps#hide-applications). | ||
|
||
### Service discovery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a more descriptive title? Also... can we specify that it is is the reverse proxy is configured within authentik? Should that be one of the regular steps in the "authentik configuration" section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the reverse-proxy is not within authentik or the service. I can rename the title if you want but it should have it's own section IMO. Tho, it's technically the config to make it work with the service. As you wish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One can configure a reverse proxy within authentik (@BeryJu ??), but if for sure this one is not configured there, then let's leave as is.
|
||
To enable OIDC functionality in ownCloud, follow these steps: | ||
|
||
1. **Navigate to the Market**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I can google correctly, Market is the app used to access Marketplace... do we want to say Market or Marketplace here? https://marketplace.owncloud.com/
|
||
The location of the `config.php` file depends on your deployment method. Consult the setup guide for your chosen deployment method to identify the file’s location within your installation. | ||
|
||
:::note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why indented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK; The rest of the section is and prettier didn't complain. Can remove if you want? whatever makes more sense
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: 4d62 <[email protected]>
sdko/feat/integration/pickup-10943-owncloud
Closes #10943
Details
REPLACE ME
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)