flows: clear flow state before redirecting to final URL #12788
Merged
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jens Langhammer <[email protected]>
|
/cherry-pick version-2024.12 |
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12788 +/- ##
==========================================
+ Coverage 92.70% 92.77% +0.07%
==========================================
Files 769 769
Lines 38912 38920 +8
==========================================
+ Hits 36072 36109 +37
+ Misses 2840 2811 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jens Langhammer <[email protected]>
BeryJu
changed the title
Signed-off-by: Jens Langhammer <[email protected]>
BeryJu
force-pushed
the
providers/oauth2/clear-context-before-redirect
branch
from
35ce708 to
48c020b
Compare
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-95fd34d9c0960cfae4454e6c85c0ccceeafb5c96
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-95fd34d9c0960cfae4454e6c85c0ccceeafb5c96Afterwards, run the upgrade commands from the latest release notes. |
Signed-off-by: Jens Langhammer <[email protected]>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
* providers/oauth2: clear flow state before redirecting to final URL Signed-off-by: Jens Langhammer <[email protected]> * make flow executor invocation correct Signed-off-by: Jens Langhammer <[email protected]> * actually we can do this centrally Signed-off-by: Jens Langhammer <[email protected]> * make sure the state is really clean Signed-off-by: Jens Langhammer <[email protected]> --------- Signed-off-by: Jens Langhammer <[email protected]>
BeryJu
added a commit
that referenced
this pull request
Jan 24, 2025
…12788) (#12801) flows: clear flow state before redirecting to final URL (#12788) * providers/oauth2: clear flow state before redirecting to final URL * make flow executor invocation correct * actually we can do this centrally * make sure the state is really clean --------- Signed-off-by: Jens Langhammer <[email protected]> Co-authored-by: Jens L. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
If a user re-loads the flow URL of an authorization flow after having used it, there may be left overs from the OAuth2 provider in the context which causes the flow to error. This PR clears the state before redirecting away.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)