web: Fix issue where Codemirror partially applies OneDark theme. #12811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reported in goauthentik#4622 - Partially fixed via fd9ce53
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs canceled.
|
GirlBossRush
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12811 +/- ##
==========================================
- Coverage 92.75% 92.75% -0.01%
==========================================
Files 769 769
Lines 38926 38926
==========================================
- Hits 36107 36105 -2
- Misses 2819 2821 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jens Langhammer <[email protected]>
BeryJu
added a commit
to BeryJu/gravity
that referenced
this pull request
Jan 25, 2025
Signed-off-by: Jens Langhammer <[email protected]>
kensternberg-authentik
added a commit
that referenced
this pull request
Jan 27, 2025
* main: (26 commits) website: bump docusaurus-plugin-openapi-docs from 4.3.1 to 4.3.2 in /website (#12844) core: bump aws-cdk-lib from 2.176.0 to 2.177.0 (#12842) lifecycle/aws: bump aws-cdk from 2.176.0 to 2.177.0 in /lifecycle/aws (#12845) web: Fix issue where Codemirror partially applies OneDark theme. (#12811) ci: fix container build always attempting to push (#12810) lifecycle: better pre release test (#12806) rbac: exclude permissions for internal models (#12803) web: bump store2 from 2.14.3 to 2.14.4 in /web (#12805) website: integrations-all: update doc titles to start with "integrate with" (#12775) web/flows: fix `login` / `log in` inconsistency (#12526) flows: clear flow state before redirecting to final URL (#12788) core: bump goauthentik.io/api/v3 from 3.2024122.2 to 3.2024122.3 (#12793) core: bump kubernetes from 31.0.0 to 32.0.0 (#12794) core: bump pydantic from 2.10.5 to 2.10.6 (#12795) core: bump msgraph-sdk from 1.17.0 to 1.18.0 (#12796) core: bump selenium from 4.28.0 to 4.28.1 (#12797) core: bump ruff from 0.9.2 to 0.9.3 (#12798) website/integrations: Add troubleshooting part to Synology guide (#12681) core: fix permissions for admin device listing (#12787) website/docs: Flesh out Google Workspaces SAML. (#12701) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
First reported in #4622, partially fixed via fd9ce53
This one was tricky to track down since Codemirror's API docs omit full examples of how themes should be applied.
Before
After
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)