Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Verification Certificate to SAML source #615

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

matthias-bruhse
Copy link
Contributor

Fixes part of #596.

This only adds the Verification Certificate option to the SAML source. I did not have time to fully implement the Icon setting as well, with it being more complicated due to the different API endpoints for uploads and URLs and therefore input options. I do have a branch in my fork that allows setting the icon via URL which is my use case. Might be useful as a starting point, if you get around to work on it.

@matthias-bruhse matthias-bruhse requested a review from a team as a code owner January 3, 2025 10:37
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.29%. Comparing base (7e6942e) to head (75b77b9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/resource_source_saml.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   79.32%   79.29%   -0.04%     
==========================================
  Files         101      101              
  Lines       11474    11484      +10     
==========================================
+ Hits         9102     9106       +4     
- Misses       1901     1905       +4     
- Partials      471      473       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit f7fdd65 into goauthentik:main Jan 3, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants