Merge pull request #27 from AtharvDalal/fix/limitConsumerPromiseHandler

fix: add try-catch to limitConsumerPromiseHandler
gobeam · Feb 1, 2025 · 9b9a61b · 9b9a61b
2 parents 4a624a3 + b13e389
commit 9b9a61b
Showing 1 changed file with 7 additions and 12 deletions.
diff --git a/src/auth/auth.service.ts b/src/auth/auth.service.ts
@@ -214,19 +214,14 @@ export class AuthService {
    */
   async limitConsumerPromiseHandler(
     usernameIPkey: string
-  ): Promise<[RateLimiterRes, RateLimiterRes]> {
-    return new Promise((resolve) => {
-      this.rateLimiter
-        .consume(usernameIPkey)
-        .then((rateLimiterRes) => {
-          resolve([rateLimiterRes, null]);
-        })
-        .catch((rateLimiterError) => {
-          resolve([null, rateLimiterError]);
-        });
-    });
+  ): Promise<[RateLimiterRes | null, RateLimiterRes | null]> {
+    try {
+      const rateLimiterRes = await this.rateLimiter.consume(usernameIPkey);
+      return [rateLimiterRes, null];
+    } catch (rateLimiterError) {
+      return [null, rateLimiterError];
+    }
   }
-
   /**
    * get user profile
    * @param user