Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ErrorObject and Error classes' initialization #849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor ErrorObject and Error classes' initialization #849

wants to merge 1 commit into from

Commits on May 3, 2020

  1. Refactor ErrorObject and Error classes' initialization 

    Currently, we allow raising errors from vm with any given string. This
is a bad practice because any internal error should have a corresponding
error class.

This PR fixes this by only accepting pre-defined error types (enum) when
initializing error objects. It also checks every error type (int) has a
corresponding name (string) during vm initialization, which saves us the
work to visually sync the 2 lists manually.
    @st0012
    st0012 committed May 3, 2020
    Configuration menu
    Copy the full SHA
    d2b2734 View commit details
    Browse the repository at this point in the history