Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloader: Make time range configurable to download advisories from #413

Merged
merged 13 commits into from
Jul 28, 2023
Merged

Downloader: Make time range configurable to download advisories from #413

merged 13 commits into from
Jul 28, 2023

Conversation

s-l-teichmann
Copy link
Contributor

This is part of #394

@s-l-teichmann s-l-teichmann changed the title Downloader interval Downloader: Make time range to download advisories from configurable Jul 26, 2023
@s-l-teichmann s-l-teichmann changed the title Downloader: Make time range to download advisories from configurable Downloader: Make time range configurable to download advisories from Jul 26, 2023
ThomasJunk
ThomasJunk previously approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works.

@JanHoefelmeyer JanHoefelmeyer dismissed ThomasJunk’s stale review July 28, 2023 06:19

The merge-base changed after approval.

JanHoefelmeyer
JanHoefelmeyer previously approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-l-teichmann s-l-teichmann dismissed JanHoefelmeyer’s stale review July 28, 2023 07:06

The merge-base changed after approval.

JanHoefelmeyer
JanHoefelmeyer previously approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@s-l-teichmann s-l-teichmann dismissed JanHoefelmeyer’s stale review July 28, 2023 07:33

The merge-base changed after approval.

ThomasJunk
ThomasJunk approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works

ThomasJunk
ThomasJunk previously approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and Works

@JanHoefelmeyer JanHoefelmeyer dismissed ThomasJunk’s stale review July 28, 2023 07:38

The merge-base changed after approval.

JanHoefelmeyer
JanHoefelmeyer approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ThomasJunk
ThomasJunk approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice to me and still works

@JanHoefelmeyer JanHoefelmeyer merged commit 8a9dd6e into main Jul 28, 2023
1 check passed
@JanHoefelmeyer JanHoefelmeyer mentioned this pull request Aug 2, 2023
Closed
@s-l-teichmann s-l-teichmann deleted the downloader-interval branch September 27, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanHoefelmeyer JanHoefelmeyer JanHoefelmeyer approved these changes

@ThomasJunk ThomasJunk ThomasJunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-l-teichmann @ThomasJunk @JanHoefelmeyer