Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregator: Add support for client certificates and extra header #424

Merged
merged 8 commits into from
Aug 17, 2023
Merged

Aggregator: Add support for client certificates and extra header #424

merged 8 commits into from
Aug 17, 2023

Conversation

s-l-teichmann
Copy link
Contributor

Part of #395

JanHoefelmeyer
JanHoefelmeyer previously approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanHoefelmeyer JanHoefelmeyer self-requested a review August 3, 2023 08:22
JanHoefelmeyer
JanHoefelmeyer previously approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm & works

@JanHoefelmeyer JanHoefelmeyer mentioned this pull request Aug 3, 2023
Closed
JanHoefelmeyer
JanHoefelmeyer approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

bernhardreiter
bernhardreiter approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@bernhardreiter bernhardreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanHoefelmeyer JanHoefelmeyer merged commit f4d00cd into main Aug 17, 2023
2 checks passed
@s-l-teichmann s-l-teichmann deleted the aggregator-client-certs branch August 17, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanHoefelmeyer JanHoefelmeyer JanHoefelmeyer approved these changes

@bernhardreiter bernhardreiter bernhardreiter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-l-teichmann @bernhardreiter @JanHoefelmeyer