Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema validation: Add AssertFormat flag to schema compiler #475

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Schema validation: Add AssertFormat flag to schema compiler #475

merged 1 commit into from
Oct 4, 2023

Conversation

s-l-teichmann
Copy link
Contributor

Solves #474

@s-l-teichmann s-l-teichmann linked an issue Sep 30, 2023 that may be closed by this pull request
Schema validation seems to ignore formats #474
Open
@s-l-teichmann s-l-teichmann mentioned this pull request Sep 30, 2023
Open
@ThomasJunk
Copy link
Contributor

Running ./csaf_validator bsi-2022-0001.json in main results in "bsi-2022-0001.json" passes the schema validation.

Running the same on schema-validation-assert-format results in "bsi-2022-0001.json" passes the schema validation.

LGTM and works

JanHoefelmeyer
JanHoefelmeyer approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works (tested via https://github.com/cisagov/CSAF/blob/971b6976d1ce52a710025aef920dba72d3a0675e/csaf_files/OT/white/2023/icsa-23-159-02.json

@JanHoefelmeyer JanHoefelmeyer merged commit 666913e into main Oct 4, 2023
3 checks passed
@s-l-teichmann s-l-teichmann deleted the schema-validation-assert-format branch November 2, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanHoefelmeyer JanHoefelmeyer JanHoefelmeyer approved these changes

@ThomasJunk ThomasJunk ThomasJunk approved these changes

@tschmidtb51 tschmidtb51 Awaiting requested review from tschmidtb51

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema validation seems to ignore formats
3 participants
@s-l-teichmann @ThomasJunk @JanHoefelmeyer