Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API examples: move csaf_searcher to a lower prio place #489

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

s-l-teichmann
Copy link
Contributor

The csaf_searcher (here renamed to purls_searcher) is not a top level tool of the csaf_distribution.
It it just a little API example and should be treated as such.
As the whole API infrastructure is WIP we should not suggest that we give
the same grants to the examples as for the real tools.

JanHoefelmeyer
JanHoefelmeyer previously approved these changes Nov 1, 2023
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ThomasJunk
ThomasJunk previously approved these changes Nov 2, 2023
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (suggested minor wording changes)

ThomasJunk
ThomasJunk previously approved these changes Nov 2, 2023
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@s-l-teichmann s-l-teichmann merged commit 26c630d into main Nov 2, 2023
1 check passed
@s-l-teichmann s-l-teichmann deleted the api-examples branch November 2, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

csaf_searcher does not provide version
3 participants