Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Intevation's JSONPath fork #490

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Use Intevation's JSONPath fork #490

merged 2 commits into from
Nov 2, 2023

Conversation

s-l-teichmann
Copy link
Contributor

As PaesslerAG/jsonpath#39 is still pending we use our fork
till upstream is moving forward.

ThomasJunk
ThomasJunk approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested some of our tools.
Works.

JanHoefelmeyer
JanHoefelmeyer approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-l-teichmann s-l-teichmann merged commit 21fa981 into main Nov 2, 2023
1 check passed
@s-l-teichmann s-l-teichmann deleted the intevation-jsonpath branch November 2, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanHoefelmeyer JanHoefelmeyer JanHoefelmeyer approved these changes

@ThomasJunk ThomasJunk ThomasJunk approved these changes

@bernhardreiter bernhardreiter Awaiting requested review from bernhardreiter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
4 participants
@s-l-teichmann @ThomasJunk @JanHoefelmeyer @bernhardreiter