Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C# examples to High-level Multiplayer documentation #9798

Conversation

ShawnHardern
Copy link
Contributor

Adds C# examples to High-level Multiplayer documentation

@skyace65 skyace65 added enhancement topic:dotnet area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:multiplayer labels Aug 22, 2024
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to the .NET documentation!

I made a few comments regarding consistency with the GDScript code and C# code-style. I have not tested that the code works, but as long as it's equivalent to the GDScript I assume it does. I have, however, tested whether it compiles successfully.

tutorials/networking/high_level_multiplayer.rst Outdated Show resolved Hide resolved
tutorials/networking/high_level_multiplayer.rst Outdated Show resolved Hide resolved
tutorials/networking/high_level_multiplayer.rst Outdated Show resolved Hide resolved
tutorials/networking/high_level_multiplayer.rst Outdated Show resolved Hide resolved
tutorials/networking/high_level_multiplayer.rst Outdated Show resolved Hide resolved
tutorials/networking/high_level_multiplayer.rst Outdated Show resolved Hide resolved
tutorials/networking/high_level_multiplayer.rst Outdated Show resolved Hide resolved
tutorials/networking/high_level_multiplayer.rst Outdated Show resolved Hide resolved
tutorials/networking/high_level_multiplayer.rst Outdated Show resolved Hide resolved
@ShawnHardern
Copy link
Contributor Author

Thanks for contributing to the .NET documentation!

I made a few comments regarding consistency with the GDScript code and C# code-style. I have not tested that the code works, but as long as it's equivalent to the GDScript I assume it does. I have, however, tested whether it compiles successfully.

Hey @raulsntos thanks so much for the review 🥳, I did copy most of it from a working implementation of that lobby example I did in c# 😁 will add suggested changes

@ShawnHardern ShawnHardern force-pushed the update-high-level-multiplayer-csharp branch from 98be324 to 2adce89 Compare August 22, 2024 20:42
@ShawnHardern ShawnHardern force-pushed the update-high-level-multiplayer-csharp branch from 0248264 to f9be250 Compare August 22, 2024 20:52
@ShawnHardern ShawnHardern force-pushed the update-high-level-multiplayer-csharp branch from 4a5c796 to 5ffa23a Compare August 23, 2024 09:17
@ShawnHardern
Copy link
Contributor Author

updated references to _playerInfo and access modifiers 👍🏻

@ShawnHardern ShawnHardern force-pushed the update-high-level-multiplayer-csharp branch from 639ffdb to c4a17ab Compare August 23, 2024 17:18
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@AThousandShips AThousandShips merged commit f3bf2ca into godotengine:master Aug 23, 2024
1 check passed
@AThousandShips
Copy link
Member

Thanks!

@ShawnHardern ShawnHardern deleted the update-high-level-multiplayer-csharp branch August 23, 2024 17:27
@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.1 cherrypick:4.2 enhancement topic:dotnet topic:multiplayer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants