Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update certain example code snippets to use the new syntax #9805

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Update certain example code snippets to use the new syntax #9805

merged 1 commit into from
Aug 23, 2024

Conversation

gongpha
Copy link
Contributor

@gongpha gongpha commented Aug 22, 2024

Update certain example code snippets that still use the legacy syntax of call_deferred and connect. The changes are :

  • Replace Object.call_deferred to Callable.call_deferred
  • Replace Object.connect to Signal.connect

@Mickeon Mickeon requested a review from skyace65 August 22, 2024 19:55
@Mickeon Mickeon added the area:manual Issues and PRs related to the Manual/Tutorials section of the documentation label Aug 22, 2024
@mhilbrunner mhilbrunner merged commit 3b888cb into godotengine:master Aug 23, 2024
1 check passed
@mhilbrunner
Copy link
Member

Merged. Thanks and congrats on your first merged contribution!

@gongpha gongpha deleted the v3-style-to-v4-style branch August 23, 2024 14:04
@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@Mickeon Mickeon Mickeon approved these changes

@skyace65 skyace65 Awaiting requested review from skyace65

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gongpha @mhilbrunner @Mickeon