Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codespell path and spelling errors #9811

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix codespell path and spelling errors #9811

merged 1 commit into from
Aug 26, 2024

Conversation

Piralein
Copy link
Member

@Piralein Piralein commented Aug 23, 2024 •
edited
Loading

  • Replace development with contributing in codespell path
  • Fix spelling errors
  • Fix indentation of bash commands in gdextension docs

I don't know why github ci doesn't detect this problems, but using codespell locally does.

@Piralein Piralein added bug github_actions Pull requests that update GitHub Actions code labels Aug 23, 2024
@Piralein Piralein force-pushed the spellcheck branch 4 times, most recently from 332973d to 1456bf1 Compare August 23, 2024 11:46
@Piralein Piralein changed the title Update the spellcheck ci command Update the codespell ci command Aug 23, 2024
@Piralein Piralein changed the title Update the codespell ci command Fix codespell path and spelling errors Aug 25, 2024
@Piralein Piralein added cherrypick:4.3 area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Aug 25, 2024
@Piralein Piralein marked this pull request as ready for review August 25, 2024 16:58
@mhilbrunner mhilbrunner merged commit 7628f87 into godotengine:master Aug 26, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you!

@Piralein Piralein deleted the spellcheck branch August 27, 2024 08:36
@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Piralein @mhilbrunner @AThousandShips