Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kbd description in gdextension docs system. #9996

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

Ivorforce
Copy link
Contributor

@dalexeev dalexeev added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:gdextension labels Sep 25, 2024
@dalexeev
Copy link
Member

Could you please remove the following line as well? I think it's because of copy-paste from RichTextLabel tutorial. You don't need to handle meta_clicked in Editor Help.

| **Must be handled with the "meta_clicked" signal to have an effect,** see :ref:`doc_bbcode_in_richtextlabel_handling_url_tag_clicks`.

Note that Editor Help BBCodes are currently documented 3 times:

@Ivorforce
Copy link
Contributor Author

Ivorforce commented Sep 25, 2024

Could you please remove the following line as well? I think it's because of copy-paste from RichTextLabel tutorial. You don't need to handle meta_clicked in Editor Help.

Done

Note that Editor Help BBCodes are currently documented 3 times:

Yeah, it would be good to de-duplicate this info in a future PR (Edit: #9998).

@paddy-exe
Copy link
Contributor

Needs a squash though @Ivorforce

@Ivorforce
Copy link
Contributor Author

Isn't that possible from the GUI?
image

@paddy-exe
Copy link
Contributor

paddy-exe commented Sep 26, 2024

@Ivorforce While it is technically possible it is generally recommended to be done from the contributor directly. Please read the appropriate section for the contributor documentation: https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#the-interactive-rebase

@Ivorforce
Copy link
Contributor Author

An upside of the squash-merge is that the tests don't have to run again :)

@mhilbrunner mhilbrunner merged commit c689e0e into godotengine:master Sep 28, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you! Merged.

@Ivorforce Ivorforce deleted the patch-2 branch September 28, 2024 12:49
@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:gdextension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants