Add functionalities to fix invalid cells and clear all cells in GridMap
#101902
+50
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tygyh
changed the title
Added functionalities to fix invalid cells and clear all cells in GridMap(Adopted)
AThousandShips
changed the title
(Adopted)GridMap
tygyh
force-pushed
the
gridmap-fix
branch
2 times, most recently
from
9b2411a to
eb9f1f8
Compare
|
I've indented and unindented the failing rows back and forth and the test still fails. Why? |
|
You're using spaces for indentation instead of tabs. |
…dMap Changes made: * Added condition to `GridMap::set_mesh_library` to update only if new library is different from old one * Added `GridMap::fix_invalid_cells` taking inspiration from `TileMap::fix_invalide_tiles` * Added menu entry to clear cells in `GridMapEditor` * Added menu entry to fix tiles in `GridMapEditor`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopts PR #37136 which closes #37124.
All I've done is rebase the branch.