Add a project setting to control reflection filter mode #83172
+179
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
reflection-add-filter-setting
branch
from
0bbc0e4
to
ca88309
Compare
The default is bilinear filtering as before, but nearest-neighbor filtering can now be chosen for a retro look. This affects sky radiance map and ReflectionProbe specular light. This also marks additional settings as requiring a restart, as noticed during testing.
Calinou
force-pushed
the
reflection-add-filter-setting
branch
from
ca88309
to
06db9a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is bilinear filtering as before, but nearest-neighbor filtering can now be chosen for a retro look.
This affects sky radiance map and ReflectionProbe specular light.
This also marks additional settings as requiring a restart, as noticed during testing.
Testing project: test_reflection_nearest_neighbor.zip
Preview
Without ReflectionProbe
Linear
simplescreenrecorder-2023-10-11_23.36.07.mp4
Nearest
simplescreenrecorder-2023-10-11_23.35.48.mp4
With ReflectionProbe
Linear
simplescreenrecorder-2023-10-11_23.36.00.mp4
Nearest
simplescreenrecorder-2023-10-11_23.35.40.mp4
TODO