Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for ReflectionProbe #97541

Closed
wants to merge 4 commits into from
Closed

Conversation

Gurka2
Copy link

@Gurka2 Gurka2 commented Sep 27, 2024

Added tests for the class Reflection Probe

The tests test the class getters and setters and the function get aabb.
This is what was asked in the issue #43440.

@Gurka2 Gurka2 requested review from a team as code owners September 27, 2024 13:22
@KoBeWi KoBeWi added this to the 4.4 milestone Sep 27, 2024
@AThousandShips AThousandShips changed the title Tests for the class Reflection Probe Add unit tests for ReflectionProbe Sep 27, 2024
@Calinou
Copy link
Member

Calinou commented Oct 1, 2024

Your pull request contains an unrelated commit (64a08e7 (#97541)). Could you look into removing it? Running the following locally on your fork's branch should do the trick:

git revert --no-edit https://github.com/godotengine/godot/pull/97541/commits/64a08e74f084bb3aa61c72f17a3a2286dfdc60df
git rebase -i HEAD~3
# Edit the file that appears to change the "pick" word on the *last* two lines with "fixup", save and quit.

git commit --amend
# Change the commit message to match the original changes.

# Force push changes (required, since this rewrites history in your fork).
git push -f

See Pull request workflow for more information 🙂

@Gurka2
Copy link
Author

Gurka2 commented Oct 1, 2024

Thanks for the guide! I think i fixed the commit now, hope this helps! 🙂

@AThousandShips
Copy link
Member

Superseded by:

@AThousandShips AThousandShips removed this from the 4.4 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants