Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blurred content of embedded windows #97745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scgm0
Copy link
Contributor

@scgm0 scgm0 commented Oct 2, 2024

Fix #54030
I honestly don't know if I'm doing it the right way, but the issue seems to be forgotten and after a flurry of attempts I'm getting good results.
before:
图片
after:
图片
example:
embedded-window.zip

@hsvfan-jan
Copy link

In the screenshot, the circles of Test2 and Test3 seem to have become an octagon (the newly introduced white outline probably making it a full circle I'd assume)

@scgm0
Copy link
Contributor Author

scgm0 commented Oct 2, 2024

In the screenshot, the circles of Test2 and Test3 seem to have become an octagon (the newly introduced white outline probably making it a full circle I'd assume)

It seems to be a problem caused by viewport_set_global_canvas_transform. I don’t know where the specific problem is.

@scgm0 scgm0 force-pushed the Fix-blurred-content-of-embedded-windows branch from c328cec to 7646cfa Compare October 2, 2024 20:59
@KoBeWi KoBeWi added this to the 4.4 milestone Oct 2, 2024
@scgm0 scgm0 force-pushed the Fix-blurred-content-of-embedded-windows branch from 7646cfa to 4e10173 Compare October 3, 2024 14:02
@scgm0
Copy link
Contributor Author

scgm0 commented Oct 3, 2024

In the screenshot, the circles of Test2 and Test3 seem to have become an octagon (the newly introduced white outline probably making it a full circle I'd assume)

When I manually assign the radio_unchecked icon in the theme (radio_unchecked.svg was copied from godot), there is no white border around the icon, so maybe the problem is related to the theme cache?
图片
图片

@scgm0 scgm0 force-pushed the Fix-blurred-content-of-embedded-windows branch 5 times, most recently from 7ec188d to 335d9b1 Compare October 5, 2024 08:11
@scgm0 scgm0 force-pushed the Fix-blurred-content-of-embedded-windows branch from 335d9b1 to 02bb81e Compare October 5, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants